feat: Add clamp() method in TimeTrait#10143
Open
patel-vansh wants to merge 4 commits intocodeigniter4:4.8from
Open
feat: Add clamp() method in TimeTrait#10143patel-vansh wants to merge 4 commits intocodeigniter4:4.8from
clamp() method in TimeTrait#10143patel-vansh wants to merge 4 commits intocodeigniter4:4.8from
Conversation
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
patel-vansh
commented
Apr 25, 2026
Comment on lines
+873
to
+883
| if ($start instanceof DateTimeInterface && ! $start instanceof self) { | ||
| $start = static::createFromInstance($start, $this->locale); | ||
| } elseif (is_string($start)) { | ||
| $start = new static($start, $this->getTimezone(), $this->locale); | ||
| } | ||
|
|
||
| if ($end instanceof DateTimeInterface && ! $end instanceof self) { | ||
| $end = static::createFromInstance($end, $this->locale); | ||
| } elseif (is_string($end)) { | ||
| $end = new static($end, $this->getTimezone(), $this->locale); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I really don't like this way. But I didn't found any current method that would cleanly return the static instance from either DateTimeInterface, self and string. So, maybe create a method for this?
michalsn
reviewed
Apr 25, 2026
Member
michalsn
left a comment
michalsn
left a comment
There was a problem hiding this comment.
I'm not convinced this should be added to the framework core.
I think implementing something like: between(), min(), and max() would be more useful and a better fit for this class, and that is also closer to how popular packages like Carbon and Chronos handle it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
clamp($start, $end)inTimeTraitclass.This method works like this:
This method is useful in places where user input should be between predefined range.
Checklist: